Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35012 )
Change subject: samsung/exynos,qualcomm/ipq: Avoid conflicting DRAM_START
......................................................................
Patch Set 2:
I think that would mean I have to include <arch/memlayout.h> in the middle of rules.h to make it work. Is that the preferred route to take?
No, I think we should decouple this fully from memlayout. Either rules.h should directly check for CONFIG(ARCH_X86) (since I think that's the only arch-specific difference we have, that may be easiest for now), or we should add <arch/rules.h> files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c41052542b215de8af3be858ca7a229e4206ecf
Gerrit-Change-Number: 35012
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 20 Aug 2019 19:35:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment