[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Update fsp params for Jasper Lake

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38461 )

Change subject: soc/intel/tigerlake: Update fsp params for Jasper Lake
......................................................................

Patch Set 22:

(3 comments)

https://review.coreboot.org/c/coreboot/+/38461/10/src/soc/intel/tigerlake/fs... 
File src/soc/intel/tigerlake/fsp_params_jsl.c:

https://review.coreboot.org/c/coreboot/+/38461/10/src/soc/intel/tigerlake/fs... 
PS10, Line 138: params->SdCardGpioCmdPadTermination = 0x1F;
> Set the PU/PD configuration for SD card CMD GPIO PAD, agree needs to be moved to main board gpio con […]

Done

https://review.coreboot.org/c/coreboot/+/38461/10/src/soc/intel/tigerlake/in... 
File src/soc/intel/tigerlake/include/soc/pci_devs.h:

https://review.coreboot.org/c/coreboot/+/38461/10/src/soc/intel/tigerlake/in... 
PS10, Line 125: #define PCH_DEV_SLOT_STORAGE	0x1a
              : #define  PCH_DEVFN_EMMC		_PCH_DEVFN(STORAGE, 0)
              : #define  PCH_DEV_EMMC		_PCH_DEV(STORAGE, 0)
> No, guarded for JSL now.

Done

https://review.coreboot.org/c/coreboot/+/38461/10/src/soc/intel/tigerlake/ro... 
File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:

https://review.coreboot.org/c/coreboot/+/38461/10/src/soc/intel/tigerlake/ro... 
PS10, Line 80: temporary
> This was a wrong comment, we are not setting the override UPD(CpuRatioOverride) here, instead settin […]

Done