Attention is currently required from: Furquan Shaikh, Sunwei Li, Weimin Wu, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57105 )
Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57105/comment/48d30dd5_8be67838
PS4, Line 9: Base on patch: https://review.coreboot.org/c/coreboot/+/57111,
As git operates with hashes, please also use the hashes: Based on commit b9c22e09 (util/sconfig: Compare probe conditions for override device match), …
Is it the right change-set though? I do not see the connection yet.
https://review.coreboot.org/c/coreboot/+/57105/comment/ade867bf_b9c1a179
PS4, Line 9: Base
Based
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a
Gerrit-Change-Number: 57105
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Ginger Zhang
zhangqingchun@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 06:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment