[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Intel Xeon Scalable Processor support

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )

Change subject: soc/intel: Add Intel Xeon Scalable Processor support
......................................................................

Patch Set 26:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38548/21/src/soc/intel/xeon_sp/rese... 
File src/soc/intel/xeon_sp/reset.c:

https://review.coreboot.org/c/coreboot/+/38548/21/src/soc/intel/xeon_sp/rese... 
PS21, Line 21: void chipset_handle_reset(uint32_t status)
             : {
             : 	switch (status) {
             : 	case FSP_STATUS_RESET_REQUIRED_5: /* Global Reset */
             : 		die("Global Reset not implemented!\n");
             : 		break;
             : 	default:
             : 		printk(BIOS_ERR, "unhandled reset type %x\n", status);
             : 		die("unknown reset type");
             : 		break;
             : 	}
             : }
> This is a stub code. We are going to implement this in future.

if it is unimplemented, it is fine. But then it probably should just die unconditionally saying its unimplemented. If this function needs to behave in this specific way (ignore some reset request types and halt on others), please document why this is done in way. Otherwise it looks like copypasta.