Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33225 )
Change subject: soc/intel/braswell/smbus.c: Add support for i2c mode block write
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/33225/14/src/soc/intel/braswell/smbus.c
File src/soc/intel/braswell/smbus.c:
https://review.coreboot.org/#/c/33225/14/src/soc/intel/braswell/smbus.c@53
PS14, Line 53: pci_write_config32(dev, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN);
This should only be done after we know SMBUS host controller is not busy. […]
On CB:3800 patchset #13 the comment was that only smbus register must be accessed in smbus.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33225
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50c1a03f624b3ab3b987d4f3b1d15dac4374e48a
Gerrit-Change-Number: 33225
Gerrit-PatchSet: 14
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 19 Jun 2019 09:24:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment