Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jincheng Li, Ronak Kanabar, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80728?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/meteorlake: Select MRC_CACHE_USING_MRC_VERSION
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80728/comment/32a75d0d_1618b295 :
PS3, Line 12:
Thank you for the update. I am sorry to bother, but commit messages should be self-contained. I have the impression, that you expect knowledge from the next commit. More background is needed, so the reviewer does not need to verify the correctness and get the whole picture.
From the next change-set I84fdcfbf3c833a7ccb259a1a1d4be0bcfe291dc3 I gather `default y if UDK_VERSION >= 202302`. Why was it added like this? Why is this now only added to Meteor Lake and not all other SoCs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80728?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10594df7c8fdc5cfe9b68975e01ae65859735544
Gerrit-Change-Number: 80728
Gerrit-PatchSet: 3
Gerrit-Owner: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 28 Feb 2024 12:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment