13 Mar
2020
13 Mar
'20
5:12 p.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38434 )
Change subject: nb/intel/haswell: Tidy up code and comments ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/38434/7/src/northbridge/intel/haswe... PS7, Line 117: #define MCHBAR8(x) (*((volatile u8 *)(DEFAULT_MCHBAR + (x))))
Oops... […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/38434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I926289304acb834f9b13cd7902801798f8ee478a
Gerrit-Change-Number: 38434
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 00:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: David Hendricks david.hendricks@gmail.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment