Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: Add support for OCP platform TiogaPass ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@7 PS4, Line 7: Add support for OCP platform TiogaPass Please add a prefix.
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@15 PS4, Line 15: was is
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@17 PS4, Line 17: ifconfig ip is the successor.
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@22 PS4, Line 22: does do
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@22 PS4, Line 22: eg. some reboots does not boot up successfully. More details? At what point does it stop in coreboot?
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@24 PS4, Line 24: 3. "lspci -vvv" causes segmentation fault. Really? Should be documented more elaborately.