Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45137 )
Change subject: drivers/aspeed/common: Support disabled P2A bridge
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45137/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45137/1//COMMIT_MSG@7
PS1, Line 7: P2A
nit: Mind adding a short sentence of what P2A means, please?
Done
https://review.coreboot.org/c/coreboot/+/45137/1//COMMIT_MSG@25
PS1, Line 25: it's
its
Done
https://review.coreboot.org/c/coreboot/+/45137/1//COMMIT_MSG@26
PS1, Line 26: 2.5seconds
add a space: `2. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3293dc35ae89c010154e02eff904ec3a68c96683
Gerrit-Change-Number: 45137
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 07 Sep 2020 12:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment