Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39390 )
Change subject: cbfstool: Build vboot library ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
I think this is okay, but it would be nice if we could somehow combine this with the futility build. util/futility/Makefile.inc also (indirectly) builds this library already, and many builds of coreboot need both tools, so it's a waste to build it twice. It would be good to make them share a build target somehow (but need to make sure that both the building as part of coreboot and the standalone building when running 'make' in the subdirectory still work).
https://review.coreboot.org/c/coreboot/+/39390/4/util/cbfstool/Makefile.inc File util/cbfstool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39390/4/util/cbfstool/Makefile.inc@... PS4, Line 143: VBOOT2="y" \ Pretty sure this doesn't do anything anymore and can be removed both here and from the firmware part.