Attention is currently required from: Angel Pons, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37191 )
Change subject: soc/intel/common/cache_as_ram.S: Add macro to clear CAR
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/37191/comment/c4db32f9_c0a38cb7
PS9, Line 11: the resulting binary
For which board? […]
Looking at the code, I see little room for divergence, so "all boards" seems to be both right and redundant, so let's leave it the way it is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec28e3f393c4fe222bfb0d5358f815691ec199ae
Gerrit-Change-Number: 37191
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 22 Jun 2021 13:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment