[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add support to initialize Memory

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )

Change subject: soc/intel/tigerlake: Add support to initialize Memory
......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39847/21/src/soc/intel/tigerlake/me... 
File src/soc/intel/tigerlake/meminit_tgl.c:

https://review.coreboot.org/c/coreboot/+/39847/21/src/soc/intel/tigerlake/me... 
PS21, Line 299: print_spd_info((unsigned char *)blk->spd_array[0]);
              : 	print_spd_info((unsigned char *)blk->spd_array[1]);
              : 	print_spd_info((unsigned char *)blk->spd_array[2]);
              : 	print_spd_info((unsigned char *)blk->spd_array[3]);
> This might. […]

That works. But, then you will have to add a special case for Memory down, since you would end up printing the same information multiple times. Adding the loop above should allow you to print the info of only the dimms that are populated based on addr_map?