Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38764 )
Change subject: intel/stm: Add platform opt-in Kconfig ......................................................................
intel/stm: Add platform opt-in Kconfig
Selecting STM on an arbitrary platform would likely result in a brick, so let's hide the prompt by default.
Change-Id: I50f2106ac05c3efb7f92fccb1e6edfbf961b68b8 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38764 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: cedarhouse1@comcast.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/security/intel/stm/Kconfig M src/soc/intel/skylake/Kconfig 2 files changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved cedarhouse1@comcast.net: Looks good to me, but someone else must approve
diff --git a/src/security/intel/stm/Kconfig b/src/security/intel/stm/Kconfig index a74eba8..144deed 100644 --- a/src/security/intel/stm/Kconfig +++ b/src/security/intel/stm/Kconfig @@ -1,9 +1,12 @@
+config PLATFORM_SUPPORTS_STM + bool + depends on SMM_TSEG
config STM bool "Enable STM" default n - depends on SMM_TSEG + depends on PLATFORM_SUPPORTS_STM select USE_BLOBS
help diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index 6277cea..ae60a63 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -44,6 +44,7 @@ select NO_FIXED_XIP_ROM_SIZE select PARALLEL_MP select PARALLEL_MP_AP_WORK + select PLATFORM_SUPPORTS_STM select PLATFORM_USES_FSP2_0 select REG_SCRIPT select SA_ENABLE_DPR