Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver ......................................................................
Patch Set 20:
(2 comments)
Given there will be only one panel, I feel we don't need to import the whole panel architecture from kukui; just merge the panel init calls to board.c should work.
Maybe merge this with the asurada display change, and make it simplified?
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 3: KUKUI_ ASURADA
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura... PS20, Line 32: #define INIT_DCS_CMD(...) \ : LCM_DCS_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ : : #define INIT_GENERIC_CMD(...) \ : LCM_GENERIC_CMD, \ : sizeof((u8[]){__VA_ARGS__}), \ : __VA_ARGS__ : : #define INIT_DELAY_CMD(delay) \ : LCM_DELAY_CMD, \ : delay : : #define INIT_END_CMD \ : LCM_END_CMD : remove these because we don't have MIPI panel this time.