11 Nov
2018
11 Nov
'18
3:56 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29577 )
Change subject: mb/emulation/qemu-i440fx|q35: Get rid of unused headers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/mainboard.c:
https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 21:
pci_write_config8 is implemented in arch/io. […]
the arch independent ramstage headers are at <device/pci_ops.h> arch/io.h is only used for PRE_RAM on x86
--
To view, visit https://review.coreboot.org/29577
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf0e4ef5b090d15ad823747fcf9219644e130fc
Gerrit-Change-Number: 29577
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 11 Nov 2018 15:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No