Attention is currently required from: Martin Roth, Matt DeVillier, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/51133 )
Change subject: Add support to switch LSPCON modes
......................................................................
Patch Set 9:
(1 comment)
File common/hw-gfx-dp_dual_mode.adb:
https://review.coreboot.org/c/libgfxinit/+/51133/comment/d5d80282_57f7652b
PS7, Line 118: Time.M_Delay (1);
I forgot what I meant with this comment.
The loop below could be written like
Timeout := Time.MS_From_Now (2_000);
loop
Read_LSPCON_Mode (Port, Mode, Success);
exit when Success;
...
Timed_Out := Time.Timed_Out (Timeout);
exit when Timed_Out;
end loop;
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/51133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Idfa9bdff47a6591000cd5092d64a4cd4f8dbdc8d
Gerrit-Change-Number: 51133
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 01 May 2021 22:09:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment