Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45759 )
Change subject: soc/intel/alderlake/ramstage: Do initial SoC commit till ramstage
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/acp...
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/acp...
PS3, Line 235: if (tbtbar && tbten) {
Should there also be a check here depending on whether or not each device (00:07.0 - 7. […]
Ack
https://review.coreboot.org/c/coreboot/+/45759/7/src/soc/intel/alderlake/fsp...
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45759/7/src/soc/intel/alderlake/fsp...
PS7, Line 216: if (config->SataPortsEnableDitoConfig[i]) {
suspect code indent for conditional statements (16, 32)
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3394f585d66b14ece67cde9e45ffa1177406f35f
Gerrit-Change-Number: 45759
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 29 Sep 2020 12:11:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment