Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36977 )
Change subject: cpu/x86/smm: Drop unused CONFIG_SMM_LAPIC_REMAP_MITIGATION symbol
......................................................................
Patch Set 8:
Patch Set 8:
I can't seem to find this mitigation in the parallel mp path, so I guess we're open to the Memory Sinkhole issue again (just that we didn't notice because the code was still here)?
I'm pretty confused by this code. Why would the lapic base be programmed to be at or close to SMMBASE? There are a lot of ranges that SMM should not conflict with...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36977
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73527a7feb6151d765295d6449262a2852b30177
Gerrit-Change-Number: 36977
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 14:08:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment