build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44323 )
Change subject: [WIP] SMM save states ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44323/1/src/cpu/intel/smm/em64t101_... File src/cpu/intel/smm/em64t101_save_state.c:
https://review.coreboot.org/c/coreboot/+/44323/1/src/cpu/intel/smm/em64t101_... PS1, Line 9: const em64t101_smm_state_save_area_t *save_state = (const em64t101_smm_state_save_area_t *)smm_get_save_state(node); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44323/1/src/cpu/intel/smm/em64t101_... PS1, Line 56: static int em64t101_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/44323/1/src/cpu/intel/smm/em64t101_... PS1, Line 61: static int em64t101_set_reg(const enum cpu_reg reg, const int node, void *in, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/44323/1/src/include/cpu/x86/save_st... File src/include/cpu/x86/save_state.h:
https://review.coreboot.org/c/coreboot/+/44323/1/src/include/cpu/x86/save_st... PS1, Line 28: int(*set_reg)(const enum cpu_reg reg, const int node, void *in, const uint8_t length); missing space after return type
https://review.coreboot.org/c/coreboot/+/44323/1/src/include/cpu/x86/save_st... PS1, Line 30: int(*apmc_node)(u8 cmd); missing space after return type