[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: devapc: add basic devapc drivers

[Nina-CM Wu (Code Review)]

Nina-CM Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )

Change subject: soc/mediatek/mt8192: devapc: add basic devapc drivers
......................................................................

Patch Set 44:

(5 comments)

https://review.coreboot.org/c/coreboot/+/46402/42/src/soc/mediatek/mt8192/de... 
File src/soc/mediatek/mt8192/devapc.c:

https://review.coreboot.org/c/coreboot/+/46402/42/src/soc/mediatek/mt8192/de... 
PS42, Line 13: &val
> writing to 0x00?

Done

https://review.coreboot.org/c/coreboot/+/46402/42/src/soc/mediatek/mt8192/de... 
PS42, Line 16: write32
> Are you trying to do […]

Done

https://review.coreboot.org/c/coreboot/+/46402/42/src/soc/mediatek/mt8192/de... 
PS42, Line 33: /* Sidband */
> ?? empty?

Done

https://review.coreboot.org/c/coreboot/+/46402/42/src/soc/mediatek/mt8192/de... 
PS42, Line 48: 0
> no need to add 0

Done

https://review.coreboot.org/c/coreboot/+/46402/42/src/soc/mediatek/mt8192/de... 
PS42, Line 54: NULL,
             : 	NULL,
             : 	NULL,
             : 	NULL,
> no need to have these NULL

Done