[coreboot-gerrit] Change in coreboot[master]: mb/google/kukui: Initialize display

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )

Change subject: mb/google/kukui: Initialize display
......................................................................

Patch Set 55:

(3 comments)

https://review.coreboot.org/c/coreboot/+/32511/54/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel.h:

https://review.coreboot.org/c/coreboot/+/32511/54/src/mainboard/google/kukui... 
PS54, Line 23: 	const char *name;  /* human readable name */
> Why don't we just use edid. […]

ascii_string currently holds only 13 chars, which can't fit manufacturer name + panel ID.

in fact I think the EDID parser should be refactored to always contain manufacturer name, but that's another story.

for now a pure larger char buffer would be the better idea.

https://review.coreboot.org/c/coreboot/+/32511/38/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel.h:

https://review.coreboot.org/c/coreboot/+/32511/38/src/mainboard/google/kukui... 
PS38, Line 32: _INIT_DCS_CMD
> Let's not start the thing that we actually want to use in the panel file with an underscore (undersc […]

I'm trying to make this compatible with kernel implementation. But well, removing a underline is fine.

https://review.coreboot.org/c/coreboot/+/32511/38/src/mainboard/google/kukui... 
PS38, Line 34: 	.len = sizeof((u8[]){__VA_ARGS__}), \
> Nice, that's way more clever than what I said!

Ack