Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38350 )
Change subject: soc/intel/broadwell: Don't use _ADR and _HID ......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38350/8/src/soc/intel/broadwell/acp... File src/soc/intel/broadwell/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/38350/8/src/soc/intel/broadwell/acp... PS8, Line 157: Device (SDMA) My Broadwell laptop has the following code:
Scope (_SB.PCI0.SDMA) { Name (_HID, "INTL9C60" /* Intel Baytrail SOC DMA Controller */) // _HID: Hardware ID Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { Return (LCRS (SMD0, SB00, SIR0)) }
Method (_HRV, 0, NotSerialized) // _HRV: Hardware Revision { Return (^^LPCB.CRID) /* _SB_.PCI0.LPCB.CRID */ } }
Scope (_SB.PCI0.SDMA) { Name (_ADR, 0x00150000) // _ADR: Address }
iasl does not complain about having both _HID and _ADR.