Attention is currently required from: Felix Held, Jason Glenesk, Martin Roth, Matt DeVillier, Maximilian Brune, Raul Rangel.
Fred Reitberger has posted comments on this change by Fred Reitberger. ( https://review.coreboot.org/c/coreboot/+/68122?usp=email )
Change subject: soc/amd/common: Support sbin ucode files ......................................................................
Patch Set 9:
(3 comments)
File src/soc/amd/common/block/cpu/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/68122/comment/07ee330a_ac0fdcdf?usp... : PS9, Line 32: # if there is both a sbin and bin microcode only include the bin one to keep the old behaviour
This only covers the case if there is both an sbin and bin (like currently in mendocino). […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/68122/comment/f8c50815_fd6ca647?usp... : PS9, Line 52: extract-bytes = $(shell echo $(shell od -A n -N $(2) -j $(3) -t $(4) $(1))) one of the minor concerns I had with this patch and `od` directly is that we are assuming this always will run on a little endian build machine. That's probably a safe assumption, but if we really need to be safe it looks like there is a `--endian=little` flag that might do the right thing on a big endian machine?
https://review.coreboot.org/c/coreboot/+/68122/comment/5d989b3f_c27b9b03?usp... : PS9, Line 52: extract-bytes = $(shell echo $(shell od -A n -N $(2) -j $(3) -t $(4) $(1))) for consistency, the call to `od` here should probably use the long options format instead of the short, to match the call above on line 28
ex: use `--address-radix` instead of `-A`, etc