Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36093 )
Change subject: mb/lenovo/x200: Add ThinkPad X301 as a variant ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36093/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36093/4//COMMIT_MSG@25 PS4, Line 25: : TODO: repurpose and/or rename flag H8_DOCK_EARLY_INIT (introduced in : CB:4294 ) for h8-using devices without a dock. For the moment just adding an empty function in ramstage is fine, but it could be done in a followup commit
https://review.coreboot.org/c/coreboot/+/36093/4/Documentation/mainboard/len... File Documentation/mainboard/lenovo/x301.md:
https://review.coreboot.org/c/coreboot/+/36093/4/Documentation/mainboard/len... PS4, Line 7: replaces replaced
https://review.coreboot.org/c/coreboot/+/36093/4/Documentation/mainboard/len... PS4, Line 21: (you might need to add the chip to the IFD VSCC list) If you can match the ID's found the the VSCC table to the chip names in flashrom and create a list here that would be great.
https://review.coreboot.org/c/coreboot/+/36093/4/src/mainboard/lenovo/x200/K... File src/mainboard/lenovo/x200/Kconfig:
https://review.coreboot.org/c/coreboot/+/36093/4/src/mainboard/lenovo/x200/K... PS4, Line 26: select H8_DOCK_EARLY_INIT if BOARD_LENOVO_X301
This is the "dirty hack" I use to fight an old dirty hack -- H8_DOCK_EARLY_INIT, which may need repu […]
No please don't use this and link an empty implementation of the function. The best thing to do (can be follow up commit) is to add a new Kconfig option like 'H8_NO_DOCK_INIT'.
https://review.coreboot.org/c/coreboot/+/36093/3/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/nvs.h:
https://review.coreboot.org/c/coreboot/+/36093/3/src/southbridge/intel/i8280... PS3, Line 137: global_nvs_t
This reminds me that this has to go to the sb dir.
Nothing. It's more like a note to self that this should be moved.