Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42916 )
Change subject: supermicro/x11-lga1151/gpio: 1/5 Decode raw register values ......................................................................
Patch Set 6:
(1 comment)
I'm unsure if splitting the changes is really worth it or if the conversion can be done in a single commit
https://review.coreboot.org/c/coreboot/+/42916/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42916/6/src/mainboard/supermicro/x1... PS6, Line 580: PWROK
No, I decided to set 0, since 3h = Reserved. […]
You have to think it the other way round. What is specified in gpio.h currently (0x3) is the logical value (RSMRST), which gets converted by the table rst_map_com2 in src/soc/intel/skylake/gpio.c to 0x0 (chipset value).
That means, the original chipset value was 0x0 but I had to convert it to the logical value (see commit 71b1ed8f7).
So my suggestion would be: instead of doing the conversion in step 5/5 just do it here and abandon 5/5