Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37587 )
Change subject: mb/google/kohaku: Update TCC offset setting
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37587/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37587/1/src/mainboard/google/hatch/...
PS1, Line 5: tcc_offset
variants/baseboard/devicetree.cb
baseboard already has 10.
do you still need to set this?
or you can remove it and use baseboard setting directly.
thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4b53de3a53bc39c1cd0f7626ae23d4c11a7a3db
Gerrit-Change-Number: 37587
Gerrit-PatchSet: 1
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-Comment-Date: Mon, 09 Dec 2019 02:35:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment