Attention is currently required from: Stefan Reinauer, Paul Menzel, David Hendricks, Julius Werner, Felix Held.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51825 )
Change subject: Documentation/contributing/coding_style: remove bug-causing rule
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
I did a quick google search and it does seem that people now accept the value of "always use {}" for C. Using {} on single lines is a recommended practice:
https://wiki.sei.cmu.edu/confluence/display/c/EXP19-C.+Use+braces+for+the+bo...
Key point: " indentation gives strong (but misleading) guidance to the structure."
absolutely. White space has no meaning in C, and I worry about depending on something with no meaning to provide meaning.
From a convenience point of view, I use 3 languages for firmware now, and 2 of them (Rust, Go) don't allow the option of NOT using {}. I am finding it jarring going back and forth now to C. I realize this is a little thing, but it it's nicer when such similar languages are a little bit more the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06422d4f6ce448766e50c7684bbeaa55ae825899
Gerrit-Change-Number: 51825
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Stefan Reinauer
reinauer@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 25 Mar 2021 22:59:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment