Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44074 )
Change subject: volteer: Create lindar variant ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 9: /* Copied from baseboard and may need to change for the new variant. */ I'd prefer if this would be corrected here instead of on CB:44079
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44074/8/src/mainboard/google/voltee... PS8, Line 2: I'd prefer if this would be filled in here instead of on CB:44080