build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information ......................................................................
Patch Set 1:
(14 comments)
File src/drivers/usb/acpi/usb_acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/0238ab56_8773a34c PS1, Line 57: printk(BIOS_ERR, "Error retrieving PLD for %s \n", path); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/21f725d8_e762d33e PS1, Line 131: if (!usb_device || !usb_device->chip_info || usb_device->chip_ops != &drivers_usb_acpi_ops) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/dafc42e3_9613cca0 PS1, Line 134: if (config->use_custom_pld) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/5f263462_6df63353 PS1, Line 134: if (config->use_custom_pld) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/d4e89228_13201246 PS1, Line 135: /* Use board defined PLD */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/b0aa8177_fd5bc956 PS1, Line 136: memcpy(&pld, &config->custom_pld, sizeof(pld)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/9ebc81d3_47c17bdb PS1, Line 136: memcpy(&pld, &config->custom_pld, sizeof(pld)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/c49eb39c_c65aa163 PS1, Line 137: } else { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/1c834059_7725ed16 PS1, Line 137: } else { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/b7f0ded1_d7f36c34 PS1, Line 138: /* Fill PLD strucutre based on port type */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/bccb9238_c599f4de PS1, Line 139: acpi_pld_fill_usb(&pld, config->type, &config->group); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/e6b005ae_98879e2b PS1, Line 139: acpi_pld_fill_usb(&pld, config->type, &config->group); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/e4f594bc_3e355d18 PS1, Line 140: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123192): https://review.coreboot.org/c/coreboot/+/56024/comment/03ceb598_3a20f1c7 PS1, Line 140: } please, no spaces at the start of a line