Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30742 )
Change subject: vendorcode/intel/fsp1_0/broadwell_de: Use FSP from 3rdparty/fsp
......................................................................
Patch Set 6:
How does this work for those that generate their own FSP binary and headers from source?
Unless I'm missing something, in this model, there's no option for it not to pull the FSP binary, headers, etc. from the subproject. There needs to be an option for allowing for integrating your own custom built FSP and headers and stuff.
Since for our current application we need to use a customized FSP, it looks like this would break our use case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f201218d19cf34c43a04f57458f474d8c3340d
Gerrit-Change-Number: 30742
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Jan 2019 16:34:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment