[coreboot-gerrit] [M] Change in coreboot[master]: sb/intel/lynxpoint: Use Broadwell SerialIO implementation

[Matt DeVillier (Code Review)]

Attention is currently required from: Angel Pons.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46969?usp=email )

Change subject: sb/intel/lynxpoint: Use Broadwell SerialIO implementation
......................................................................

Patch Set 7:

(5 comments)

File src/southbridge/intel/lynxpoint/acpi/serialio.asl:

https://review.coreboot.org/c/coreboot/+/46969/comment/b5fc0964_743e1c75 :
PS7, Line 23: DeRefOf (Arg0) &= 0xFFFFFFFC
            : 	Local0 = DeRefOf (Arg0) // Read back after writing
one or both of these derefs is the issue:
ACPI Error: needed type reference, found integer

https://review.coreboot.org/c/coreboot/+/46969/comment/273c2732_81b03c53 :
PS7, Line 226: ^^LPD0 (RefOf (SPCS))
same deref error here

https://review.coreboot.org/c/coreboot/+/46969/comment/3c17f8c4_87bda2eb :
PS7, Line 231: ^^LPD3 (RefOf (SPCS))
and here

https://review.coreboot.org/c/coreboot/+/46969/comment/1f080144_ff43f04d :
PS7, Line 294: ^^LPD0 (RefOf (SPCS))
deref error

https://review.coreboot.org/c/coreboot/+/46969/comment/1d2c9f78_57f804c6 :
PS7, Line 299: ^^LPD3 (RefOf (SPCS))
here too