build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41054 )
Change subject: Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: Ia972d587ac917901e7534c9265119fed4a7f2880 ......................................................................
Patch Set 1:
(10 comments)
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 314: for( i = 0; i < gpio_communities; i++ ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 314: for( i = 0; i < gpio_communities; i++ ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 314: for( i = 0; i < gpio_communities; i++ ) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 316: for( j = 0; j < comm->num_groups; j++ ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 316: for( j = 0; j < comm->num_groups; j++ ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 316: for( j = 0; j < comm->num_groups; j++ ) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 317: for ( k = 0; k < group_curr->size; k++ ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 317: for ( k = 0; k < group_curr->size; k++ ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 320: for ( l = 0; l < GPIO_NUM_PAD_CFG_REGS; l++ ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41054/1/src/soc/intel/common/block/... PS1, Line 320: for ( l = 0; l < GPIO_NUM_PAD_CFG_REGS; l++ ) { space prohibited before that close parenthesis ')'