build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31597 )
Change subject: security/vboot: Add fmap measurements
......................................................................
Patch Set 35:
(4 comments)
https://review.coreboot.org/#/c/31597/35/src/security/vboot/vboot_crtm.c
File src/security/vboot/vboot_crtm.c:
https://review.coreboot.org/#/c/31597/35/src/security/vboot/vboot_crtm.c@68
PS35, Line 68: if (fmap_locate_area_as_rdev(ifd_static[i], &fmap) == 0) {
line over 80 characters
https://review.coreboot.org/#/c/31597/35/src/security/vboot/vboot_crtm.c@80
PS35, Line 80: if (fmap_locate_area_as_rdev(ifd_dynamic[i], &fmap) == 0) {
line over 80 characters
https://review.coreboot.org/#/c/31597/35/src/security/vboot/vboot_crtm.c@85
PS35, Line 85: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR,
line over 80 characters
https://review.coreboot.org/#/c/31597/35/src/security/vboot/vboot_crtm.c@239
PS35, Line 239: pcr_index = get_pcr_index(CONFIG_VBOOT_MEASURED_BOOT_CBFS_RUNTIME_DATA, name);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31597
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7e4972805fbc8d19ab55d1f5e506836791c7bf0
Gerrit-Change-Number: 31597
Gerrit-PatchSet: 35
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Jun 2019 11:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment