Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82292?usp=email )
Change subject: soc/intel/xeon_sp: Dump proximity domain info per types ......................................................................
soc/intel/xeon_sp: Dump proximity domain info per types
Some proximity domain info are type specifics, e.g. base/size/dev are effective for PD_TYPE_GENERIC_INITIATOR, but not for PD_TYPE_PROCESSOR. Dump info per their type.
TEST=Build and boot on intel/archercity
Change-Id: I7e722a0577bba954efba3e91cc152c758c001d68 Signed-off-by: Shuo Liu shuo.liu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/82292 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/soc/intel/xeon_sp/numa.c 1 file changed, 6 insertions(+), 3 deletions(-)
Approvals: Patrick Rudolph: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/xeon_sp/numa.c b/src/soc/intel/xeon_sp/numa.c index 81331ed..1f0b9a3 100644 --- a/src/soc/intel/xeon_sp/numa.c +++ b/src/soc/intel/xeon_sp/numa.c @@ -19,9 +19,12 @@ printk(BIOS_DEBUG, "\tproximity domain %d:\n", i); printk(BIOS_DEBUG, "\t\ttype:%d\n", pds.pds[i].pd_type); printk(BIOS_DEBUG, "\t\tsocket_bitmap:0x%x\n", pds.pds[i].socket_bitmap); - printk(BIOS_DEBUG, "\t\tdevice:%s\n", pds.pds[i].dev ? dev_path(pds.pds[i].dev) : ""); - printk(BIOS_DEBUG, "\t\tbase(64MB):0x%x\n", pds.pds[i].base); - printk(BIOS_DEBUG, "\t\tsize(64MB):0x%x\n", pds.pds[i].size); + if (pds.pds[i].pd_type == PD_TYPE_GENERIC_INITIATOR) { + printk(BIOS_DEBUG, "\t\tdevice:%s\n", + pds.pds[i].dev ? dev_path(pds.pds[i].dev) : ""); + printk(BIOS_DEBUG, "\t\tbase(64MB):0x%x\n", pds.pds[i].base); + printk(BIOS_DEBUG, "\t\tsize(64MB):0x%x\n", pds.pds[i].size); + } } }