Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32022 )
Change subject: northbridge/amd/pi, mb/amd/bettong: Fix null pointer checks
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32022/1/src/northbridge/amd/pi/00730F01/dimm...
File src/northbridge/amd/pi/00730F01/dimmSpd.c:
https://review.coreboot.org/#/c/32022/1/src/northbridge/amd/pi/00730F01/dimm...
PS1, Line 27: AGESA_STATUS AmdMemoryReadSPD(UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PARAMS *info)
line over 80 characters
Done
https://review.coreboot.org/#/c/32022/1/src/northbridge/amd/pi/00730F01/dimm...
PS1, Line 47: [info->SocketId][info->MemChannelId][info->DimmId];
line over 80 characters
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie578787c3c26a1f3acb4567c135486667e88a888
Gerrit-Change-Number: 32022
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Mar 2019 18:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment