Attention is currently required from: Martin Roth, Paul Menzel, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78221?usp=email )
Change subject: soc/amd/genoa: Add SMI support
......................................................................
Patch Set 7:
(3 comments)
File src/soc/amd/genoa/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/78221/comment/7aae1b7d_917529a2 :
PS7, Line 9: 59
i'd say that this should be 64; the highest sci map is scimap_63 in FCH::SMI::SCIMAP15
https://review.coreboot.org/c/coreboot/+/78221/comment/87f58ec8_0011c9eb :
PS7, Line 56:
one tab too many. same in lines 62 and 63
https://review.coreboot.org/c/coreboot/+/78221/comment/d6993712_9e4405d7 :
PS7, Line 84: SMITYPE_WLAN_BT_PME
SMITYPE_ESPI1_WAKE_PME
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78221?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I491f4075cef8976e4b0762752c9e2e3c2ef886d5
Gerrit-Change-Number: 78221
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 22:00:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment