Attention is currently required from: Angel Pons.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46919 )
Change subject: cpu/intel/haswell: Raise PSI1 threshold to 20A
......................................................................
Patch Set 14:
(1 comment)
File src/cpu/intel/haswell/haswell_init.c:
https://review.coreboot.org/c/coreboot/+/46919/comment/a00053f0_34fdd67f
PS14, Line 263: msr.hi |= (0x14 << (32 - 32)); /* PSI1 threshold - 20A. */
For the record: There's at least one Haswell ULT laptop whose vendor firmware uses these values (Asus X555LA with i5-4210U), soc/intel/broadwell also uses them too. This was also tested on a google/peppy Chromebook and still boots.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I979ea1b4ba2962bd0c55cfb9d0c291f32cf5fcad
Gerrit-Change-Number: 46919
Gerrit-PatchSet: 14
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 10 Jan 2021 18:28:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment