Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33622 )
Change subject: vendorcode/amd/pi: Add code for merlinfalcon ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Where did these files come from? Since the StoneyPI package is backward compatible and you're building from that code, why not use 00670F00 for this product too?
It's been a while I started, but there was some issue when I tried, just don't remember what. Will write more when I remember (or try again).
I can't remember and it's gone... whatever it was, it was probably fixed together with something else... so yes, I don't need the new files, just the modified ones.
Richard, I believe you're capable of figuring it out... You shouldn't put vendorcode here on behalf of AMD if you can't reproduce the steps. Please try to compare the files with 00670F00, for example, to see if that's where you got them. (I'll repeat my previous question, of course, which is "why not use 00670F00?") In the event you needed to modify what you received from AMD, that needs to be documented _very_ well.