Patch Set 2:

Patch Set 2:

Patch Set 2:

Where did these files come from? Since the StoneyPI package is backward compatible and you're building from that code, why not use 00670F00 for this product too?

It's been a while I started, but there was some issue when I tried, just don't remember what. Will write more when I remember (or try again).

I can't remember and it's gone... whatever it was, it was probably fixed together with something else... so yes, I don't need the new files, just the modified ones.

Richard, I believe you're capable of figuring it out... You shouldn't put vendorcode here on behalf of AMD if you can't reproduce the steps. Please try to compare the files with 00670F00, for example, to see if that's where you got them. (I'll repeat my previous question, of course, which is "why not use 00670F00?") In the event you needed to modify what you received from AMD, that needs to be documented _very_ well.

View Change

To view, visit change 33622. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3341f6a1ef2561a6391d3db8c54f6bdd09b0c0e
Gerrit-Change-Number: 33622
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: Charles Marslett <charles.marslett@silverbackltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 27 Jun 2019 02:43:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment