Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44686 )
Change subject: security/intel/stm: Add options for STM build ......................................................................
Patch Set 12: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/44686/12/src/security/intel/stm/Kco... File src/security/intel/stm/Kconfig:
https://review.coreboot.org/c/coreboot/+/44686/12/src/security/intel/stm/Kco... PS12, Line 93: indicatea indicate*s*
https://review.coreboot.org/c/coreboot/+/44686/10/src/security/intel/stm/Mak... File src/security/intel/stm/Makefile:
https://review.coreboot.org/c/coreboot/+/44686/10/src/security/intel/stm/Mak... PS10, Line 14: rm -rf build; \ : mkdir -p build; \ : cd build; \
Not quite sure what you mean here. I did remove the 'rm -rf build' as the cmake causes a rebuild. […]
See comment in Makefile.inc
https://review.coreboot.org/c/coreboot/+/44686/12/src/security/intel/stm/Mak... File src/security/intel/stm/Makefile:
https://review.coreboot.org/c/coreboot/+/44686/12/src/security/intel/stm/Mak... PS12, Line 36: #rm -rf $(project_dir) This won't work for a submodule. Best approach would be to delegate clean/distclean to the STM Makefiles (and mask failures if already cleaned)
https://review.coreboot.org/c/coreboot/+/44686/10/src/security/intel/stm/Mak... File src/security/intel/stm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44686/10/src/security/intel/stm/Mak... PS10, Line 21: 3rdparty/stm/Stm/build/StmPkg/Core/stm.bin
The issue here is that if the developer changes any of the STM parameters, then the build will not g […]
Making `3rdparty/stm/Stm/build/StmPkg/Core/stm.bin` depend on `$(objutil)/kconfig/conf` should be good enough. This is the same dependency that `$(obj)/config.h` uses.