Patch set 12:Code-Review +1
4 comments:
File src/security/intel/stm/Kconfig:
Patch Set #12, Line 93: indicatea
indicate*s*
File src/security/intel/stm/Makefile:
rm -rf build; \
mkdir -p build; \
cd build; \
Not quite sure what you mean here. I did remove the 'rm -rf build' as the cmake causes a rebuild. […]
See comment in Makefile.inc
File src/security/intel/stm/Makefile:
Patch Set #12, Line 36: #rm -rf $(project_dir)
This won't work for a submodule. Best approach would be to delegate clean/distclean to the STM Makefiles (and mask failures if already cleaned)
File src/security/intel/stm/Makefile.inc:
Patch Set #10, Line 21: 3rdparty/stm/Stm/build/StmPkg/Core/stm.bin
The issue here is that if the developer changes any of the STM parameters, then the build will not g […]
Making `3rdparty/stm/Stm/build/StmPkg/Core/stm.bin` depend on `$(objutil)/kconfig/conf` should be good enough. This is the same dependency that `$(obj)/config.h` uses.
To view, visit change 44686. To unsubscribe, or for help writing mail filters, visit settings.