Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44782 )
Change subject: fw_config: Add caching to successfully probed fields ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44782/1/src/lib/fw_config.c File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/44782/1/src/lib/fw_config.c@75 PS1, Line 75: #if ENV_RAMSTAGE
Ya, but you added that. That isn't necessary, though.
I didn't want to waste the space in bootblock, verstage and romstage (cache size is already 512 bytes, probably 1K when we inevitably double the size of fw_config).
https://review.coreboot.org/c/coreboot/+/44782/1/src/lib/fw_config.c@112 PS1, Line 112: match = true;
I think you should put this here, since it's supposed to be tied to the device tree parsing. […]
That's true, but when I wrote this, I intentionally did it this way for the manually called ones as well, say TABLETMODE, which seems less likely to get used in devtree, as it's probably consumed by the EC, which carries the accel/gyro.