15 May
2019
15 May
'19
6:16 a.m.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )
Change subject: mb/google/hatch: Update GPIO settings ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32176/5/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32176/5/src/mainboard/google/hatch/variants/... PS5, Line 109: Set to NF1
Can you add a comment indicating why this is set to NF1 even though it is unused.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/32176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2
Gerrit-Change-Number: 32176
Gerrit-PatchSet: 6
Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 May 2019 04:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment