David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42302 )
Change subject: mb/google/volteer/var/terrador: Update gpio settings and overridetree.cb
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42302/10/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/terrador/gpio.c:
https://review.coreboot.org/c/coreboot/+/42302/10/src/mainboard/google/volte...
PS10, Line 100: /* E12 : SPI1_MISO_IO1 ==> PEN_ALERT_ODL */
: PAD_CFG_GPI(GPP_E12, NONE, DEEP),
:
Because you are overriding one of the GPIOs in the baseboard's early_gpio_table[] array, you need to […]
Done. Copy the GPP_E12 entry in that early_gpio_table. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42302
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bf9081b034bc4cd566dde45586be8309cdbb4a3
Gerrit-Change-Number: 42302
Gerrit-PatchSet: 11
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 18 Jun 2020 05:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment