John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32432 )
Change subject: soc/intel/cnl: Enable VT-d ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/32432/4/src/soc/intel/cannonlake/acpi.c File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/#/c/32432/4/src/soc/intel/cannonlake/acpi.c@308 PS4, Line 308: /* Add RMRR entry */
This should have been caught in the previous CL. […]
done
https://review.coreboot.org/#/c/32432/4/src/soc/intel/cannonlake/acpi.c@368 PS4, Line 368: (1 << 2)
Can you please fix DMA_CTRL_PLATFORM_OPT_IN_FLAG in acpi. […]
Updated by simply adding DMA_CTRL_PLATFORM_OPT_IN_FLAG into soc/intel/common/block/include/intelblocks/acpi.h. I feel it should be handled properly in arch/x86/include/arch/acpi.h.
https://review.coreboot.org/#/c/32432/4/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32432/4/src/soc/intel/cannonlake/romstage/fs... PS4, Line 119: #if CONFIG(SOC_INTEL_COMMON_VTD)
Can this not be a runtime check? […]
done