Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42944 )
Change subject: soc/amd/common: Use ACPIMMIO_BASE() in ASL ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42944/2/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl:
https://review.coreboot.org/c/coreboot/+/42944/2/src/mainboard/google/kahlee... PS2, Line 21: Method (_CRS, 0x0, Serialized) { : Name (RBUF, ResourceTemplate () { : // Memory resource is for MISC FCH register set. : // It is needed for enabling the clock. : Memory32Fixed(ReadWrite, ACPIMMIO_BASE(MISC), 0x100) : }) : : Return (RBUF) : }
We can do that in a follow up, not this CL.
The reason to do this in this change is because IASL does not like additions on Memory32Fixed values (e.g. `ACPIMMIO_BASE(MISC)`), which is why this change fails to build.