build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71603 )
Change subject: Revert "{cpu/nb}/amd/family16: Remove platform" ......................................................................
Patch Set 1:
(12 comments)
File src/northbridge/amd/agesa/family16kb/chip.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/606ec202_1c46d2bb PS1, Line 7: { open brace '{' following struct go on the same line
File src/northbridge/amd/agesa/family16kb/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/1a460bcb_55829456 PS1, Line 51: if (__f1_dev[0] == NULL || __f0_dev[0] == NULL || fx_devs == 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/f8a58b6c_00317cc3 PS1, Line 72: if (dev && dev->enabled) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/dc59373c_6a20d164 PS1, Line 300: else { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/b4e17c68_d0ab5da2 PS1, Line 315: else { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/9db3d3f7_e3f78b27 PS1, Line 393: if (res) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/ae4e67a7_e13bbd03 PS1, Line 438: if (base_k > 4 * 1024 * 1024) break; // don't need to go to check trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/ed0d28df_d653711b PS1, Line 462: for (link = dev->link_list; link; link = link->next) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/7d66dc8d_5ca6f77f PS1, Line 525: else { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/10e79092_3a964b5d PS1, Line 541: if (link->children) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/860a4095_6a32656f PS1, Line 592: if (ApicIdCoreIdSize) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167477): https://review.coreboot.org/c/coreboot/+/71603/comment/1b298054_dd5fc9ff PS1, Line 699: if (dev->path.type == DEVICE_PATH_DOMAIN) { braces {} are not necessary for any arm of this statement