[coreboot-gerrit] Change in ...coreboot[master]: soc/apollolake: Add generation of DMAR table

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30990 )

Change subject: soc/apollolake: Add generation of DMAR table
......................................................................

Patch Set 5: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/30990/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30990/5//COMMIT_MSG@7 
PS5, Line 7: Add generation of DMAR table
Shorter:
> Generate DMAR table

https://review.coreboot.org/#/c/30990/5//COMMIT_MSG@10 
PS5, Line 10: 
Tested how?

https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c 
File src/soc/intel/apollolake/acpi.c:

https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c@224 
PS5, Line 224: /* Now that it is not needed any more hide P2SB device again. */
With the comment above, I believe this comment could be removed.