[coreboot-gerrit] Change in coreboot[master]: src/arch/x86:Add support for low power idle table

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )

Change subject: src/arch/x86:Add support for low power idle table
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c 
File src/arch/x86/acpi.c:

https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c@1253 
PS4, Line 1253: __weak void soc_residency_counter(struct acpi_lpit_native *lpit_native)
> We can also have the generic code in src/acpi/acpi.c btw. […]

Got it. This solution seems to be good,thanks. I will implement the same way and update the patch.

https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c@1255 
PS4, Line 1255: 	lpit_native->residency_counter.space_id = 0x7F;
> why is this "the" default for all platforms?

Some of this values are platform independent and depends on acpi specs.Working on it to implement 2 different values for for cpu and system level residencies.