Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40126 )
Change subject: Drop explicit NULL initializations from `device_operations`
......................................................................
Patch Set 6:
Patch Set 6:
What was the DEVICE_NOOP introduced for then?
It was introduced in CB:7283 to replace the various equivalents around the tree. Personally, if the default value is null, then it's simpler to not have anything at all and check for null before dereferencing the function pointer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b
Gerrit-Change-Number: 40126
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Apr 2020 09:42:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment